Comment on
Vulnerability [XKCD]
Why not 2# or 4b?!
Comment on
Vulnerability [XKCD]
Why not 2# or 4b?!
Comment on
Instructions told me to tie a reef knot - I did a zeppelin bend instead
Well that’s gonna void your warranty.
Comment on
What is behind the current Lemmy meme about 4 being a private key?
Reply in thread
Ain’t no way I’m starting from 0 if the standard key is 256-bit
Comment on
Tips for Reviewing Code
Well for starters, having one person be the reviewer is not a great idea.
One reason is that you have a single point of failure, as you are now discovering.
Another reason is that it creates a codebase that reinforces one persons biases.
Thirdly it can (potentially) silo knowledge, so if you only ever work on the data layer, you have no insight into any other part of the codebase.
I would encourage you to try get others in on the reviewing effort. I’d prefer assigning people to review, rather than just hoping someone steps up. (There is a saying; If it is everyone’s job, it is nobody’s job)
The actual review is multi part,
Step 1: understand what was supposed to happen. (Was this change supposed to update a dependency? Update some text? Add a button?).
Step 2: confirm the code builds. (I ain’t reviewing shit if it doesn’t even compile).
Step 3: reading the code. You’re looking out for a bunch of different stuff; access control, function size, file size, design patterns, cyclomatic complexity, weird names, weird types, overly broad implementations, complexity where simplicity should be, threading shenanigans, lots of comments (usually bad). The list is nearly endless, but trust your gut, if something feels off that’s called a Code Smell, and it warrants further digging.
It is very ok to reach out to the author and ask why choices were made, if they don’t have a firm answer, it’s time to get concerned.
Once the code looks good, I move on to tests. Check that they build and pass.
Then start looking at what they actually do.
If a function takes an input, I like to add 3 kinds of test: Expected good inputs (like valid passwords, or correctly formatted date strings) Expected bad inputs (zeros and empty strings, malformed inputs) and lastly: Fucking chaos (+-int_max, the first chapter of Moby Dick, actual face rolling on the keyboard) a function with one test is not tested at all.
Finally, at long last, actually run the code. Verify the code does what it set out to do.
PR Approved.
Comment on
You can have it both ways
Reply in thread
Is your intent to obfuscate your meaning through use of a lexicon outside the common parlance?
Comment on
You can have it both ways
Reply in thread
Arse
Comment on
That's a no
Merging at the last minute is the correct way to do it.
Zipper merge, you fucks!
Comment on
Windows 10 is EOL in October 2025
You can recommend what you like. As soon as Windows 10 can’t play the latest games I’m off to Linux.
Eat my whole ass, Microsoft.
Comment on
Food safety
Why would you expect tap water to kill bacteria?
You’re washing bugs and dirt off.
Comment on
Anon wants to talk about video games
Anon wants to talk about the games they like, not the games other people like.
Comment on
The latest shares from conservatives is getting extra weird
Same with AOC, tbh.
Didn’t one of the Jan6ers steal her shoes?
Comment on
Don’t you lie to me
Buy 1GB of Ram
Comment on
The TV industry finally concedes that the future may not be in 8K
Reply in thread
Look, we can’t have TVs that last 15 years anymore!
We need to keep people buying every year or two. Otherwise line not go up! Don’t you understand that this is about protecting The Economy?!
Comment on
I'm at a roulette table. I only bet on red. When I lose I triple my bet, when I win I restart. Is this a roulette strategy?
This is the Martingale system, it will 100% work if you have infinite money and can bet infinite amounts.
Comment on
Informed investment
Ok! Time to relax. Sashi is a shitposter.
Comment on
Downtown Toronto faces a crush of rising office vacancies that could threaten building valuations
Oh no! Not our precious building valuations!!!
Comment on
Man digging a swimming pool in his garden in France discovers gold worth $800,000
The fact we know about this means he fucked up.
You win the lottery?
Shut
The
Fuck
Up
Comment on
Genius
“Easy”
Like 4 countries had to work on it.
Comment on
Black highlighter ≠ Erasing
This has happened before. Back when I used to browse the armpit of the internet there were classified military docs that had the same technique used.
Comment on
The fact that firefox updates when I open it instead of when I close it. Has to be the most annoying feature ever.
Would you prefer:
“Firefox Updater
This app is preventing shutdown”