Spyke

Replies

chat

Comment on

Downvotes versus upvotes

Reply in thread

As a fellow mostly-lurker, this is also how I felt about downvotes. For me I think it was also because of the concept of having a karma score for the account as a whole, rather only on individual comments.

Comment on

Here's one of my first scripts. I think it's pretty funny.

That's actually pretty good for a beginner.

Some tips (take with a grain of salt since some are just personal preference):

Make collatz take a number, and parse the number outside the loop, which also avoids needing to repeat the conversion to int. It also means that you can remove the try-catch from inside collatz, since the only place a ValueError is expected is the conversion to int.

def collatz(number):
    ...

number = None # Declare number to give it the correct scope
while True:
    try:
        number = int(input('Type in a positive integer: '))
        break
    except ValueError:
        print("Input could not be parsed")

print(collatz(number))

Avoid commenting what your code does, and instead focus on getting across the intent, like how you commented that int(number) % 2 == 0 is a check for even numbers. It is fine to leave out comments for pieces of code that are truly self explanatory.

The elif condition can be replaced with just else, since it will only be run if the if condition is false.

Format with Black, it makes things look nicer without having to deal with manual formatting.

You reached the end