Spyke

Replies

Comment on

Is there a place where you can request code reviews on opensource software?

There is a Stack Exchange community for code reviews: https://codereview.stackexchange.com/

However they have some strict rules on what is allowed so it may not be suitable for open source projects. Two problematic ones are: 1) The poster must be the author/owner of the code. You, for example, can't post code that someone else has written. 2) All code that is to be reviewed must be included in the post. You can't just link to a repository.

Comment on

has resolved one of your map notes – how to do it yourself?

StreetComplete uses OSM's built-in note system to leave the notes, so basically any OSM user can see them and react to them.

I use Vespucci now and them, but most of the time I find it too fiddly to use on the go. What I usually do is also have OsmAnd open and use its own note system to make a local audio or photo note. And when I'm home I go through the list of notes and change the things in ID or JOSM.

java

Comment on

Has anyone ever used the assert keyword? Being off by default seems to ruin the benefits.

You are not wrong that they are in a way "executable comments". Just like comments they are intended only for development/debugging and can't (shouldn't) have any influence on production code.

For example, in your sample code the if is unnecessary, because condition can't be (should not be) true. If it were, it would be a bug. Instead it should be written as:

assert !condition;
// Very long block of code

If the condition can ever be true then you shouldn't be using assert.

See also https://stackoverflow.com/a/2758645/318493

Comment on

Routing issue in OsmAnd

Can you give more information on the exact location and route? For the life of me I can't match your OsmAnd screenshot to the OSM online map. I can identify Newcastle St and the #60 highway, but I, for example, can't see where the dark green road is.

Comment on

Conventions for House Addresses

That isn't really duplicating information. Duplicating information, would be for example, to have the outline of a building and a single node both with the same information representing the same shop.

In your case you have separate buildings that each happen to share some of the information. Put the full address information on each house. That way there is a clear connection between a single object and it's data, and no additional computation is needed to collect all data to the object.

You can additionally have an area around the buildings with it's full address, if they together represent a single entity.

Comment on

Routing issue in OsmAnd

Reply in thread

Ah, ok, got it now. I couldn't zoom in enough on the map itself, I had to go into the editor.

However that bus lane seems to be tagged correctly, so OsmAnd should never be routing over it. I tried it on my phone and it routed correctly.

I can only suggest to post in a more official community such as Github Discussions. Try making a screen shot of OsmAnd actually routing along there. Also add following link to the bus lane: https://www.openstreetmap.org/way/706585631

You reached the end