Spyke

Syndicated from the fediverse. Read and engage on the original instance.

View original on programming.dev

61 replies

reddthat.com

It's not a glass, it's the

hydrationContainerManagerObjectFactory

Not to be confused with the

hydrationContainerManagerTypeFactory

Which is the template

73

Some of those patterns were actually good design, until everyone went overboard with them. Now the pendulum has swung the complete opposite way and there’s a ton of duplicate code often generated from actual templates.

16

you mean

glass Glass;

which is almost worse than stringing together random fancy words.

(Edit: added backticks for that nice mono font)

2
lemmy.today

That's not a good comment. What it is should be clear from the naming and context. A good comment explains the why when that is not obvious:

// This glass is at 50% capacity because we don't want it to overflow if it rains
40
piefed.social

And in 5 years you will wonder why the glass is under the rain because someone didn't put that in the specifications.

15

Inevitably whatever is under the glass gets wet anyway... because it's raining.

3

A software tester walks into a bar

Runs into a bar.
Crawls into a bar.
Dances into a bar.
Flies into a bar.
Jumps into a bar.

And orders:

a beer.
2 beers.
0 beers.
99999999 beers.
a lizard in a beer glass.
-1 beer.
"qwertyuiop" beers.
Testing complete.

A real customer walks into the bar and asks where the bathroom is.

The bar goes up in flames.

1
lemmy.world

If it were a vacuum the water would quickly boil away with any remaining turning to ice.

4
cenzorrllreply
piefed.ca

It wouldn't freeze unless you drop the temperature as well.

2
lemmy.ca

The phase transition from liquid to gas absorbs all the thermal energy in the remaining liquid and causes its temperature to drop to freezing point. You are familiar with this effect if you have used a tank of compressed gas; the tank gets cold as you release the gas and you might see condensation on the tank up to the liquid level.

But then the remaining ice in the glass sublimates anyway.

12
PattyMcBreply
lemmy.world

Who are you who are so wise in the ways of science?

5
lemmy.world

Opportunist... "It's an empty glass. I drank it while you were arguing."

26

Scientist.. "it's half empty because the water is slowly evaporating."

7
feddit.nl

Engineer: this glass is twice as big as it needs to be.

22
lemmy.world

//Then line 368 that checks if the comment exists will fail and will be sad

5
OwOarchistreply
pawb.social

Comment would be whether glass is being emptied or filled

What if it's neither (and unknown which it was previously), and the glass is just sitting there?

6
// This is a Glass class
class Glass {
     filled(halfFull,  halfEmpty) {
         this.halfFull;
         this.halfEmpty;
         }
}
11
programming.dev

The current legacy code I'm dealing with is full of these:

// TODO: Class description here to satisfy linter

11
OwOarchistreply
pawb.social
"""
only one line for your comment?
fucking amateur
this comment uses five lines
"""
4
xthexderreply
l.sw0.com
/*
 * this five line comment
 * is formatted C plus plus
 * and is a haiku
 */
5
xthexderreply
l.sw0.com

Eh, my bad. I figured that was somewhat optional given it's English and already kind of an adaptation. Fixing it is more effort than I'm willing to put in tho

The whole Wikipedia page on English Haiku makes it seem like there's a lot of room for interpretation

3

I figured that was somewhat optional

It is somewhat optional.

While there are certain elements that are traditionally included in a 'proper' haiku, those elements are not universal, even in very old, traditional haiku. @[email protected] is being too harsh and speaking too absolutely here. A non-traditional haiku is still a haiku.

-- Your friendly neighborhood literature major.

2

elements of the natural world in a symbolic manner

What about elements of HTML? It also has symbols.

3
/**
 * @brief This is the coffee cup class
 * 
 * This class describes a cup or mug that neatly integrates a
 * container for vectors of cCoffee instances with a fully
 * functional handle to carry the cup or mug around. Used for 
 * pretty much everything.
 */
class cTallGlass : public cGlass {
10
dan
upvote.au

AI loves inserting comments like this.

Either that or 20-line comments documenting the bugs in the old code, what this code does differently, and the exact implementation.

Comments describing the exact implementation become stale very quickly. Comments shouldn't explain what the code does (eg "add two to rowCount"); they should explain why it does it (eg "include header and footer row in count too"). Extra details are what the commit message is for, and history is what source control is for.

I call it out in a lot of my code reviews ("code looks good but clean up the AI slop comments before landing") but a lot of other developers don't care as much about code and documentation quality.

8

Commented out glass is certainly a problem (if it's not only a comment) as the instance of object is created elsewhere but there's some more problems in the code:

-Software tester removes the glass but the water still stands there in the shape of the glass.

-QA tries to pour the water in to the glass but water doesn't register and the glass doesn't fill.

-Performance testing notes that rendering the glass needs some optimization since the glass doesn't fill over 50% before being out of memory.

-Junior programmer can't get the glass to run since the liquids library wasn't locked down and got an incompatible update.

-Automation testing results in to a crash with a screenshot and logs that point out that glass frontend use the old version of the glass backend API leading the glass to freeze.

-External testing points out that there's a bug in the glass but they can't identify it.

5
Glass _glass = new Glass(); //make variable glass of type glass and make a new glass
///<captainusefuldoc>Gets the glass</captainusefuldoc>
Glass getGlass() => _glass; //get the glass in _glass
5

//This a glass // To get the quantity and type of content use
// glass->qty : float
// glass->content : glass_content

5

You should check against homi.healthyCapacity first unless you want to drown them.

3

How can you be so sure other readers will understand floating point numbers? Better include the entire IEEE 754 standard just in case.

4

IT support chatbot when the client asks how to get an empty/full glass to display: You're absolutely right! I couldn't have said it better myself: This is a glass. 😊🥛

5

Marketing: the glass is perfectly dimensioned to transport that amount of water without spilling anything! Buy yours now for a discount! Terms and conditions may apply.

3

Feel like we’re missing an overflow joke here!

Or something like: // initialise a glass using max water value as indicator that glass is unused

2