Well its public so who knows in what other package is using it.
And it's static, so who know what kind if monster is calling it from some inapropriate place.
I have seen static methods being called from translation/localization files, because "it works".
IntelliJ finds most uses in my experience unless you're doing something weird with reflection or similar. And if it's a public facing API only used by the library's consumers..– it should be used in tests at the very least! Especially if it's prone to regressions like the comment suggests
14 replies
Well its public so who knows in what other package is using it. And it's static, so who know what kind if monster is calling it from some inapropriate place. I have seen static methods being called from translation/localization files, because "it works".
IntelliJ finds most uses in my experience unless you're doing something weird with reflection or similar. And if it's a public facing API only used by the library's consumers..– it should be used in tests at the very least! Especially if it's prone to regressions like the comment suggests
There are only 7 unit test classes. 2 of which I wrote myself this month.
Somebody should tell Albert and the others, they can let this method go.
I already did so an hour ago
UPDATE: It has been merged
https://xkcd.com/1172
You know it's comming.
Alright, this is my first contribution to an open-source project, albeit indirect. I'll drink to that!
Any context?
Found it while refactoring KDE Connect Android.
Found the masterpiece: https://github.com/KDE/kdeconnect-android/blob/d41ed4d911959beef923d0d9a9c74072f0dd920a/src/org/kde/kdeconnect/Helpers/StorageHelper.java#L56
Wow, that looks like a nightmare
It has a typo
Me about to make my first contribution to KDEConnect Ü
I keep telling myself that in the ideal world, phones would be programmed in Forth.